09-14-2020, 02:48 AM
Hi Eric,
Thanks. I actually adapted Shafran Chess today also (also getting e.p. working), thinking you wouldn't likely get to it till Monday. Not only did you beat me to it, but your e.p. fix is better.
A few notes:
* The BUG line near the top can be removed, now that e.p. works.
* I'm not sure whether you meant to leave the classification property empty. Would it not be "board/war/chess"?
* The author is Isaak Grigorevich Shafran. His last name was left off in your version.
* I would think you'd want to somewhere preserve the year the game was created, both for the interest of Ludii users, and as a possible check on phylogenetic inference results.
Cheers,
Jay
Thanks. I actually adapted Shafran Chess today also (also getting e.p. working), thinking you wouldn't likely get to it till Monday. Not only did you beat me to it, but your e.p. fix is better.
A few notes:
* The BUG line near the top can be removed, now that e.p. works.
* I'm not sure whether you meant to leave the classification property empty. Would it not be "board/war/chess"?
* The author is Isaak Grigorevich Shafran. His last name was left off in your version.
* I would think you'd want to somewhere preserve the year the game was created, both for the interest of Ludii users, and as a possible check on phylogenetic inference results.
Cheers,
Jay